chore(querier): Operate on AST directly in multi-tenant querier - #24137
Draft
chaudum wants to merge 1 commit into
Draft
chore(querier): Operate on AST directly in multi-tenant querier#24137chaudum wants to merge 1 commit into
chaudum wants to merge 1 commit into
Conversation
Rework MultiTenantQuerier to operate on the AST directly instead of converting to string and re-parsing. This is step 2 of the QueryRequest.Selector to QueryRequest.Plan migration (loki-private#2709). Changes: - SelectLogs: Assign modified AST directly to Plan, eliminating the string round-trip (AST → string → parse → AST) - SelectSamples: Fix bug where Plan was not being updated after tenant selector removal; now updates Plan with modified AST - Remove unused fmt import Both methods still update Selector for backward compatibility during version-skew rollout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rework MultiTenantQuerier to operate on the AST directly instead of converting to string and re-parsing.
This is step 2 of the QueryRequest.Selector to QueryRequest.Plan migration (loki-private#2709).
Changes:
Both methods still update Selector for backward compatibility during version-skew rollout.