fix(logql): Wrap count min sketch errors with operator name - #24157
Open
hundredwatt wants to merge 3 commits into
Open
fix(logql): Wrap count min sketch errors with operator name#24157hundredwatt wants to merge 3 commits into
hundredwatt wants to merge 3 commits into
Conversation
Range queries were rejected with "count min sketches", an implementation detail users do not see in the operator they wrote. Co-authored-by: Cursor <cursoragent@cursor.com>
Range-query errors now name whichever operator produced the sketch, so a future CMS-backed function does not inherit a hardcoded approx_topk message. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the original count-min-sketch wording and add the user-facing operator name, instead of walking the AST to replace the message. Co-authored-by: Cursor <cursoragent@cursor.com>
hundredwatt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<operator> error: count min sketches are only supported on instant queries.approx_topk), so a future CMS-backed function can reuse the same path.Test plan
go test -count=1 -timeout 5m -run 'TestLogQLScripts/functions.logqltest' ./pkg/logql/internal/logqltest/go test -count=1 -timeout 3m -run 'TestErrCountMinSketchInstantOnly|TestHeapCountMinSketch|TestCountMinSketch|TestMapping|TestApproxTopk' ./pkg/logql/approx_topk(...)query and confirm the error starts withapprox_topk error:.Risks
None. Error text and operator metadata only; query behavior is unchanged.