Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

francoposa/casie tree queue sketch integration debug #8573

Closed

Conversation

francoposa
Copy link
Member

@francoposa francoposa commented Jul 1, 2024

What this PR does

To use debugging:
Change NewQueryFrontend in integration/e2emimir/services.go to use newMimirDebugServiceFromOptions

Use remote debug to attach debugger to port 18080

Must either disable breakpoints on the remote debug run config OR hit step over at least once when it attaches because delve "continue" arg is not used here.

Main test will not start all containers until query frontend container has started.

  • start main test
  • stop debugger before it starts the container
  • start remote debug with breakpoints disabled
  • main test can now continue and start the Query Frontend container
  • stop main test on breakpoint before issue happens
  • enable breakpoints on remote debug to view what is happening
  • continue main test

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@francoposa
Copy link
Member Author

[...ment/mimir-microservices-mode] % git diff
diff --git a/integration/e2emimir/services.go b/integration/e2emimir/services.go
index c83620bc8..5978028f4 100644
--- a/integration/e2emimir/services.go
+++ b/integration/e2emimir/services.go
@@ -207,7 +207,7 @@ func NewIngester(name string, consulAddress string, flags map[string]string, opt
 }
 
 func NewQueryFrontend(name string, flags map[string]string, options ...Option) *MimirService {
-       return newMimirServiceFromOptions(
+       return newMimirDebugServiceFromOptions(
                name,
                map[string]string{
                        "-target":    "query-frontend",

@chencs chencs changed the base branch from main to casie/tree-queue-sketch July 1, 2024 22:06
Base automatically changed from casie/tree-queue-sketch to main July 5, 2024 19:29
@narqo
Copy link
Contributor

narqo commented Sep 27, 2024

The CHANGELOG has just been cut to prepare for the next release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG.md document. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants