-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
francoposa/casie tree queue sketch integration debug #8573
Closed
francoposa
wants to merge
26
commits into
main
from
francoposa/casie-tree-queue-sketch-integration-debug
Closed
francoposa/casie tree queue sketch integration debug #8573
francoposa
wants to merge
26
commits into
main
from
francoposa/casie-tree-queue-sketch-integration-debug
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g previous tree queue iteration
|
chencs
force-pushed
the
casie/tree-queue-sketch
branch
from
July 1, 2024 23:00
a121631
to
bae99c7
Compare
The CHANGELOG has just been cut to prepare for the next release. Please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
To use debugging:
Change
NewQueryFrontend
inintegration/e2emimir/services.go
to usenewMimirDebugServiceFromOptions
Use remote debug to attach debugger to port
18080
Must either disable breakpoints on the remote debug run config OR hit step over at least once when it attaches because delve "continue" arg is not used here.
Main test will not start all containers until query frontend container has started.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.