Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin E2E: Expose variable list page as fixture #942

Merged
merged 15 commits into from
Jun 11, 2024

Conversation

aangelisc
Copy link
Contributor

@aangelisc aangelisc commented Jun 3, 2024

This PR updates the plugin-e2e package with some more functionality related to template variables and dashboards.

  • Exposes VariablePage to allow it to be reused

Also have fixed a typo in the dashboard delete function that was attempting to delete a data source instead.

Required for grafana/azure-data-explorer-datasource#880

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@4.12.0-canary.942.feafd59.0
npm install @grafana/plugin-e2e@1.5.0-canary.942.feafd59.0
# or 
yarn add @grafana/create-plugin@4.12.0-canary.942.feafd59.0
yarn add @grafana/plugin-e2e@1.5.0-canary.942.feafd59.0

@aangelisc aangelisc requested a review from a team as a code owner June 3, 2024 17:38
@aangelisc aangelisc requested review from oshirohugo and sunker and removed request for a team June 3, 2024 17:38
Copy link

github-actions bot commented Jun 3, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@aangelisc aangelisc added minor Increment the minor version when merged release Create a release when this pr is merged labels Jun 3, 2024
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for raising this PR @aangelisc!

Added some minor comments about the selectors and also had a question about server state. Otherwise looks great!

I know it's cumbersome to work with the selectors today, but FYI we're planning to change this so that they're no longer duplicated here and in grafana/e2e-selectors.

packages/plugin-e2e/src/e2e-selectors/types.ts Outdated Show resolved Hide resolved
packages/plugin-e2e/src/models/pages/DashboardPage.ts Outdated Show resolved Hide resolved
packages/plugin-e2e/src/models/pages/VariablePage.ts Outdated Show resolved Hide resolved
packages/plugin-e2e/src/models/pages/VariablePage.ts Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2024

CLA assistant check
All committers have signed the CLA.

@aangelisc aangelisc requested a review from sunker June 5, 2024 15:27
@sunker sunker changed the title Various plugin-e2e updates Plugin E2E: Expose variable list page as fixture Jun 11, 2024
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I'm making some final adjustments to this PR since Andreas is OOO.

Thanks again for contributing @aangelisc!

@sunker sunker merged commit 6b24810 into main Jun 11, 2024
21 checks passed
@sunker sunker deleted the andreas/update-plugin-e2e branch June 11, 2024 06:00
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@1.5.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants