Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Grails 7, Java 17, Gradle 8.10.2, Geb 7.0 and Groovy 4.0.23 #54

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

jamesfredley
Copy link
Contributor

No description provided.

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add these to the bottom of build.gradle:

bootRun.enabled = false
bootTestRun.enabled = false

Remove from build.gradle:

bootRun {
    ignoreExitValue true
    jvmArgs(
            '-Dspring.output.ansi.enabled=always',
            '-noverify',
            '-XX:TieredStopAtLevel=1',
            '-Xmx1024m')
    sourceResources sourceSets.main
    String springProfilesActive = 'spring.profiles.active'
    systemProperty springProfilesActive, System.getProperty(springProfilesActive)
}

Change the grailsVersion in GebGrailsPlugin.groovy to "7.0.0 > *"

No need to exclude "grails-app/views/error.gsp" in GebGrailsPlugin.groovy

Update or remove authorEmail in GebGrailsPlugin.groovy

build.gradle Outdated Show resolved Hide resolved
@jamesfredley jamesfredley merged commit 5397bdf into 5.0.x Sep 25, 2024
3 checks passed
@jamesfredley jamesfredley deleted the jamesfredley/grails-7 branch September 25, 2024 14:44
@matrei
Copy link
Contributor

matrei commented Sep 25, 2024

I had a look at the dependencies again in this plugin.

It makes no sense to have org.grails:grails-core as api.
It should be implementation (as it is only used for access to the GrailsPlugin class in GebGrailsPlugin) or preferably compileOnly (as it always will be provided anyways).

org.gebish:geb-spock is api (I presume because the generated functional tests uses GebSpec, and you don't want the end user to have to add that dependency). But in that case, why is not org.grails:grails-testing-support and org.grails:grails-datastore-gorm not also added as grails.testing.mixin.integration.Integration and grails.gorm.transactions.Rollback are also used in the generated test?

@jamesfredley What do you think?

@jamesfredley
Copy link
Contributor Author

@matrei My first pass was about 5 minutes and I had not looked at the dependencies other than adjusting versions. I agree with these changes.

Something like #60 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants