Test rollback document suggested modification #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
niravassar
reviewed
Apr 18, 2019
| @@ -36,7 +36,8 @@ class ExampleSpec extends Specification { | |||
|
|
|||
| The `Rollback` annotation ensures that each test method runs in a transaction that is rolled back. Generally this is desirable because you do not want your tests depending on order or application state. | |||
|
|
|||
| In Grails 3.0 tests rely on `grails.transaction.Rollback` annotation to bind the session in integration tests. Though each test method transaction is rolled back, the `setup()` method uses a separate transaction that is not rolled back. | |||
| In Grails 3.0 tests rely on `grails.transaction.Rollback` annotation to bind the session in integration tests. Though each test method transaction is rolled back, the `setup()` method uses a separate transaction that is not rolled back and the `setup()` method will be executed automatically when the tests is executed. | |||
There was a problem hiding this comment.
I think this ... is not rolled back and the setup()... should be broken into a sentence like this:
is not rolled back. The setup()
niravassar
reviewed
Apr 18, 2019
| @@ -72,6 +73,11 @@ import spock.lang.* | |||
| @Integration | |||
| @Rollback | |||
| class BookSpec extends Specification { | |||
|
|
|||
| void setup() { | |||
| // Do not use this method | |||
There was a problem hiding this comment.
These two lines should not be commented out in the example, and the comment should be
// This line will not roll back
niravassar
suggested changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.