Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join sentences with a whitespace #152

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ankushshah89
Copy link
Contributor

Join the replacetext with a whitespace. Otherwise two different sentence can be mixed. For eg:

url = http://timesofindia.indiatimes.com/tech/tech-news/Facebooks-Mark-Zuckerberg-in-India-today/articleshow/44740431.cms

from goose import Goose
g = Goose()
a = g.extract(url)
a.cleaned_text

u'NEW DELHI: Facebook co-founder Mark Zuckerberg willon Thursday attend the two-day long Internet.org summit that aims to make internet access affordable for people who do not have it globally.Zuckerberg......'

Notice that there is no space between two sentences. This creates problem when later on, we want to split the cleaned_text using some sentence tokenizer.

@ankushshah89 ankushshah89 changed the title join sentences with a withspace join sentences with a whitspace Oct 11, 2014
@ankushshah89 ankushshah89 changed the title join sentences with a whitspace join sentences with a whitespace Oct 11, 2014
@ankushshah89
Copy link
Contributor Author

the test is failing. will look into it and then reopen

@ankushshah89
Copy link
Contributor Author

only the test_donga_korean is failing. I looked at the expected in the test and even it has the same problem. The expected value doesn't have spaces after "." (period) in some of the sentences. Though, I have no idea about Korean but I guess there should always be space after every ".". So, may be the test case needs to be updated.

@ankushshah89 ankushshah89 reopened this Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant