Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3 support #220

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Add python 3 support #220

wants to merge 21 commits into from

Conversation

vetal4444
Copy link

If you run goose under python bs3 parser will not be able to use.

@hnykda
Copy link

hnykda commented Jul 8, 2015

When we can expect that this will be merged?

@xanderdunn
Copy link

+1 for merging

@Tomtomgo
Copy link

Tomtomgo commented Oct 4, 2015

+1

@Daenyth
Copy link

Daenyth commented Dec 11, 2015

ping @grangier

@hnykda
Copy link

hnykda commented Dec 11, 2015

Is there any problem with this PR? Can we help somehow or you are just ignoring it?

@thelonecabbage
Copy link

@grangier +1

Lol4t0 added a commit to Lol4t0/python-goose that referenced this pull request Jan 11, 2016
@@ -2,5 +2,6 @@ Pillow
lxml
cssselect
jieba
beautifulsoup
beautifulsoup # Only on python2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so your code will not work in python 3?

@@ -2,5 +2,6 @@ Pillow
lxml
cssselect
jieba
beautifulsoup
beautifulsoup # Only on python2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working in python 3.5.4 as it does not support beautifulsoup. Even after changing the requires.txt with beautidulsoup4 the install didnt work. Attached error file
error_goose_extract.txt

@gaussic
Copy link

gaussic commented May 8, 2018

Waiting for so long!!!

@hnykda
Copy link

hnykda commented May 8, 2018

@gaussic You actually wait for it? This project is 3 years dead. There is plethora of better solutions already, such as https://github.com/goose3/goose3 or https://github.com/codelucas/newspaper

@amirouche
Copy link

Thanks but newspaper doesn't work that well AFAIK

@amirouche
Copy link

Why are people still using beautiful soup in 2018?

@gaussic
Copy link

gaussic commented May 9, 2018

@hnykda Great, thanks man. By the way, @amirouche I'm still using BeautifulSoup 4 and it's easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants