Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new line before field description #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emilkholod
Copy link
Contributor

@emilkholod emilkholod commented May 24, 2023

If we will generate SDL schema then we get:

"""Desc 1"""
type Object1 @key(fields: "field1") {
  """Desc field 1"""
  field1: DateTime
  """Desc field 2"""
  field2: ID
  """Desc field 3"""
  field3: String
  field4: String
  field5: String
}

but by default there should be a new line before descriptions:

"""Desc 1"""
type Object1 @key(fields: "field1") {
  """Desc field 1"""
  field1: DateTime

  """Desc field 2"""
  field2: ID

  """Desc field 3"""
  field3: String
  field4: String
  field5: String
}

@emilkholod
Copy link
Contributor Author

Can anybody check this PR please?

@erikwrede
Copy link
Member

Hey there, I'll check it out more closely this week.

@coveralls
Copy link

coveralls commented Apr 30, 2024

Pull Request Test Coverage Report for Build 5068006418

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 90.553%

Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_federation/service.py 2 3 66.67%
Totals Coverage Status
Change from base Build 5063747249: -0.2%
Covered Lines: 393
Relevant Lines: 434

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants