-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example to work with Pydantic V2, add test for examples #99
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e15d15d
Add vim swap files to gitignore
dantheman39 797a4b3
Update optional fields in the examples to align with changes in Pydan…
dantheman39 0141ca3
Add a test for the examples so it's easier to test when they break
dantheman39 8cee335
Bump package version
dantheman39 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,3 +75,7 @@ dmypy.json | |
|
||
# PyCharm / IntelliJ | ||
.idea/ | ||
|
||
# vim | ||
*.swp | ||
*.swo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
from examples import departments | ||
|
||
|
||
def test_departments(): | ||
result = departments.main() | ||
assert not result.errors | ||
|
||
deps = result.data["listDepartments"] | ||
assert len(deps) == 1 | ||
|
||
employees = deps[0]["employees"] | ||
assert len(employees) == 3 | ||
|
||
def employee_by_name(employees, name): | ||
return [e for e in employees if e["name"] == name][0] | ||
|
||
jason = employee_by_name(employees, "Jason") | ||
carmen = employee_by_name(employees, "Carmen") | ||
derek = employee_by_name(employees, "Derek") | ||
|
||
# Jason is a manager | ||
assert jason["teamSize"] == 2 | ||
assert carmen.get("teamSize") is None | ||
|
||
# some sanity checks on optional fields, | ||
# knowing what the test data is | ||
assert jason.get("hiredOn") is None | ||
assert carmen.get("hiredOn") is not None | ||
assert carmen["salary"]["rating"] == "GS-9" | ||
assert derek["salary"] is None |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@necaris any opinions on the version bump being in the same or separate PR? Happy to comply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same PR seems fine to me.