Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply last child style only if not only child #241

Closed
wants to merge 4 commits into from

Conversation

Maruuka
Copy link
Contributor

@Maruuka Maruuka commented Feb 27, 2024

Apply last child style only if not only child

Title looked smaller than expected due to a css bug where both first-child and last-child were applied.

This fix will only apply subtitle styles if there are more than one child element in .title otherwise don't apply

FOR THE TEMPLATE MAINTAINER(S)

New template version checklist:

  • I have updated CITATION and CHANGELOG as appropriate.
  • I have updated lab-website-template-docs as appropriate.
  • I have checked the testbed as appropriate.

Copy link

github-actions bot commented Feb 27, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-05 03:58 UTC

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for lab-website-template ready!

Name Link
🔨 Latest commit 2a7fcbf
🔍 Latest deploy log https://app.netlify.com/sites/lab-website-template/deploys/65dd34b122c5a80008f751e1
😎 Deploy Preview https://deploy-preview-241--lab-website-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti
Copy link
Collaborator

Thanks for this, i'll incorporate this into v1.2.0 coming this week.

At a cursory glance i think in your first change, first child should remain first, not last.

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for lab-website-template ready!

Name Link
🔨 Latest commit 5b5d368
🔍 Latest deploy log https://app.netlify.com/sites/lab-website-template/deploys/65dd397b87eb550008e48fc2
😎 Deploy Preview https://deploy-preview-241--lab-website-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Maruuka
Copy link
Contributor Author

Maruuka commented Feb 27, 2024

Thanks for this, i'll incorporate this into v1.2.0 coming this week.

thanks!

At a cursory glance i think in your first change, first child should remain first, not last.

oh you are right, good catch! I transferred my local changes incorrectly.
fixed the typo

@vincerubinetti
Copy link
Collaborator

Do you know if it's possible to change the target of your PR from main to the v1.2.0 branch? The versioning workflow does checks to make sure the changelog and stuff like that has been updated, and that shouldn't be on you to update.

I'm guessing it's not possible to change the target, so you can either open a new PR with the same changes, or I can just copy and paste your changes in my own commit to v1.2.0 and tag your github user name to credit you for the fix.

@vincerubinetti
Copy link
Collaborator

Superceded by #244 . Will tag you in that for credit. The better solution ended up being just attaching manual "title" and "subtitle" classes to the spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants