-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply last child style only if not only child #241
Conversation
|
✅ Deploy Preview for lab-website-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for this, i'll incorporate this into v1.2.0 coming this week. At a cursory glance i think in your first change, first child should remain first, not last. |
✅ Deploy Preview for lab-website-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thanks!
oh you are right, good catch! I transferred my local changes incorrectly. |
Do you know if it's possible to change the target of your PR from I'm guessing it's not possible to change the target, so you can either open a new PR with the same changes, or I can just copy and paste your changes in my own commit to |
Superceded by #244 . Will tag you in that for credit. The better solution ended up being just attaching manual "title" and "subtitle" classes to the spans. |
Apply last child style only if not only child
Title looked smaller than expected due to a css bug where both
first-child
andlast-child
were applied.This fix will only apply subtitle styles if there are more than one child element in
.title
otherwise don't applyFOR THE TEMPLATE MAINTAINER(S)
New template version checklist: