Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.2.1 #247

Merged
merged 5 commits into from
Apr 1, 2024
Merged

V1.2.1 #247

merged 5 commits into from
Apr 1, 2024

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Mar 23, 2024 •
edited
Loading

  • fix bug where literal yaml date object doesn't get parsed correctly
  • fixes addition of site.url by gh-actions workflow

New template version checklist:

  • I have updated CITATION and CHANGELOG as appropriate.
  • I have updated lab-website-template-docs as appropriate.
  • I have checked the testbed as appropriate.

This was linked to issues Mar 23, 2024
Manual override of date doesn't work in citations #245
Closed
Site url not being set properly #246
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-01 19:59 UTC

@vincerubinetti
Copy link
Collaborator Author

@falquaddoomi could you take a quick look at this

falquaddoomi
falquaddoomi reviewed Apr 1, 2024
View reviewed changes
.docker/entrypoint.sh Outdated Show resolved Hide resolved
_cite/util.py Outdated Show resolved Hide resolved
@vincerubinetti vincerubinetti merged commit fcfb29f into main Apr 1, 2024
4 checks passed
@vincerubinetti vincerubinetti deleted the v1.2.1 branch April 1, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falquaddoomi falquaddoomi falquaddoomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site url not being set properly Manual override of date doesn't work in citations
2 participants
@vincerubinetti @falquaddoomi