RAM pages polishing #138
RAM pages polishing #138
Conversation
Deploying 2nicove with
|
| Latest commit: |
e38a22c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31b62761.unicove2.pages.dev |
| Branch Preview URL: | https://ram-polishing.unicove2.pages.dev |
dafuga
force-pushed
the
ram-polishing
branch
from
cc23341
to
62ca605
Compare
| let { data, debug = true }: Props = $props(); | ||
| // Seeing a weird bug with svelte where this component is rerendered with data being undefined | ||
| // This is a workaround to prevent the component from breaking the page | ||
| let { data = [], debug = true }: Props = $props(); |
There was a problem hiding this comment.
I'm not seeing any issues here with it removed. This must be your local environment?
I'd rather not leave code like this here 😅
There was a problem hiding this comment.
This is super weird, I only see the error when going from the RAM overview page to one of the other RAM pages. You're not seeing the same thing?
There was a problem hiding this comment.
No I don't see anything weird when navigating between the RAM page without this code.
There was a problem hiding this comment.
weird.. Maybe there is something different about my environment 🤔
There was a problem hiding this comment.
I just ran bun clean and I'm still seeing the errors.
There was a problem hiding this comment.
Ah actually, the above was redundant because of this line. If you remove it, you should see the error.
There was a problem hiding this comment.
I removed the redundent code above 👍
Cast to a number and leave as unknown
refactor: rename extended select option type
* refactor: use index in token select value * refactor: attempt fix on generic types * fix: type error in token select props * Refactor token select dafuga (#144) * debug: making selected a value * fix: type errors * fix: type error * chore: make format * chore: remove unused method --------- Co-authored-by: Dean Sallinen <7519573+deansallinen@users.noreply.github.com> * revert: update eslint.config.js --------- Co-authored-by: Daniel Fugere <danielfugere28@gmail.com>
No description provided.