Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to signup pages #177

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Updates to signup pages #177

merged 15 commits into from
Nov 5, 2024

Conversation

dafuga
Copy link
Contributor

@dafuga dafuga commented Oct 23, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying 2nicove with  Cloudflare Pages  Cloudflare Pages

Latest commit: 34763e4
Status: ✅  Deploy successful!
Preview URL: https://1aee9f83.unicove2.pages.dev
Branch Preview URL: https://signup-get-started-page.unicove2.pages.dev

View logs

@dafuga dafuga changed the title Signup get started page Updates to signup get started page Oct 23, 2024
@dafuga dafuga marked this pull request as ready for review October 23, 2024 23:08
@aaroncox
Copy link
Member

Broken on mobile somehow.

image

Shows Anchor text, with MetaMask logo - and when I click it loads the MetaMask instructions.

@dafuga dafuga changed the title Updates to signup get started page Updates to signup pages Oct 24, 2024
@aaroncox
Copy link
Member

aaroncox commented Oct 24, 2024

Other thoughts:

  • Between the recommended wallet at the top, and the list of other wallets, I think some sort of header needs to exist that says "Other [Type] Wallets".
  • The wallet configuration needs to have which chains it supports. If you go to signup on Jungle 4, it's just going to be Anchor and MetaMask pretty much. If you go to sign up on WAX, the Cloud Wallet needs to be included, etc.
  • The download links to each wallet need to be more precise locations, not just their homepage. Dropping them on the homepage is probably going to create a suboptimal experience, requiring a ton of extra clicks to figure out where to download it. Like for Anchor on mobile it needs to go to the app store page.
  • The wallet links should probably open in a new tab.
  • For each wallet, do we want to describe feature of account creation somehow in the design? Like when we recommend Anchor, before even clicking "Continue with Anchor Mobile", should it display information about how "Anchor allows you to securely create an account using in-app purchases" or something? This is the onboarding flow, so maybe we should focus on what the user should expect before making their selection.

@dafuga
Copy link
Contributor Author

dafuga commented Oct 25, 2024

Broken on mobile somehow.

image Shows Anchor text, with MetaMask logo - and when I click it loads the MetaMask instructions.

I'm super confused by this 😅 if you log the recommendedWallet values you can see that we're passing the Anchor Mobile logo. Not sure why it's displaying the MetaMask one..

@dafuga
Copy link
Contributor Author

dafuga commented Oct 25, 2024

Ahhhh it's because the platform detection is happening server side 😅 Not sure why the FE is not able to update the logo src though 🤔

@dafuga
Copy link
Contributor Author

dafuga commented Oct 26, 2024

Still not sure why it's happening, but making it so the page doesn't get rendered until the platform is detected in the browser fixes the issue.

@aaroncox aaroncox merged commit 32ebd3c into dev Nov 5, 2024
4 checks passed
@dafuga dafuga deleted the signup-get-started-page branch November 5, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants