Fix unit tests and Array<Never> related bugs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a878b5a.
This reverts commit 33cf264.
this is a try to fix the chaos `Never` introduced inside this library, there is a high chance change below is the final source. swiftlang/swift#64899 At least unit test passes after it removed.
There are also some resulting issues fixed in this commit too.
Issue is: now fileUrl generate random file urls for the same request, cause the digest of request body is random. There is a breaking change in swift Foundation's JSONEncoder, sortedKeys needed now. For detail, check here: https://developer.apple.com/forums/thread/735895
dafuga
approved these changes
Mar 19, 2024
dafuga
requested changes
Mar 19, 2024
dafuga
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues:
crashing on anchor-mobile-ios
greymass/anchor#1365