This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
deps: move to mini-create-react-context #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarkelov
approved these changes
Jun 14, 2021
|
When will you merge? Not working with react 17.0.2 now |
|
@happylolonly unfortunately i can't merge, because i don't have permissions |
|
@mmarkelov how about merging? It was approved several months ago... |
I don't have permission to merge |
|
@mmarkelov can you notify those who can merge? |
|
@swayok I get notifications and will look at PRs in detail when I have time. You're free to fork this code at any moment and republish under a different name or in your private registry, or use a tool like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
While peer deps were updated in #273, it was not enough actually since
create-react-contextpeerDeps range is not updated. Now it should allow clear installation of React 17Change is similar to remix-run/react-router#6692 so I believe
mini-create-react-contextis a drop-in replacement for an old libraryI was unable to launch neither project itself or docz locally to test it, but my working project with updated bundles of
react-yandex-mapsworked well (e.g. YMap, YMaps components)