Skip to content

Creating guidelines for contributing demos - #13

Open
macruzbar wants to merge 1 commit into
grpc:mainfrom
macruzbar:patch-2
Open

Creating guidelines for contributing demos#13
macruzbar wants to merge 1 commit into
grpc:mainfrom
macruzbar:patch-2

Conversation

@macruzbar

Copy link
Copy Markdown

Adding guidelines for gRPC community to contribute demos for the community meetup.
@thisisnotapril can you please help me to give this file some visibility? Thank you!

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@macruzbar

Copy link
Copy Markdown
Author

/assign @thisisnotapril

April, can you help me to give more visibility to this PR? Please feel free to add other reviewers

@chalin

chalin commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

Hi @macruzbar: I suggest that we add new content to CONTRIBUTING.md. The CONTRIBUTING.md page is in need of review, would you like for me to consider adding your demo-related prose to that file when I review it?

Base automatically changed from master to main March 12, 2021 00:33
@jsoref

jsoref commented Jun 17, 2025

Copy link
Copy Markdown

@chalin how dead is this repository?

The CONTRIBUTING file suggests master but that's gone...
https://github.com/grpc/grpc-community/blob/main/CONTRIBUTING.md?plain=1#L29-L30

This suggests PRs will be closed in 2-3 weeks, but the only two PRs have been open for a very long time:

* Unless your PR is trivial, you should expect there will be reviewer comments that you'll need to address before merging. We expect you to be reasonably responsive to those comments, otherwise the PR will be closed after 2-3 weeks of inactivity.

(I have a PR I'd be likely to make, but if this repository is dead, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants