Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For CesiumNative, use ktx library instead of ktx_read #2596

Closed
wants to merge 1 commit into from

Conversation

yunusyurtturk
Copy link

Updated content to reflect changes made by cesium-native side. . Otherwise, -DOSGEARTH_BUILD_CESIUM_NODEKIT=ON type cmake configurations were complaining about being ktx_read not found.

Cesium-native is using ktx instead of ktx_read for a while

Check cesium-native commits:
CesiumGS/cesium-native@dd35563

CesiumGS/KTX-Software#1

@yunusyurtturk
Copy link
Author

This PR fix the related update made by cesium-native side, however there are things to support versions never than cesium-native v0.33.0

There are breaking changes to be fixed, like newly introduced AppData parameter here:

https://github.com/CesiumGS/cesium-native/blame/c36ddc72d23588573470be6eddf232c80c18d0cd/CesiumIonClient/src/Connection.cpp#L250

@yunusyurtturk
Copy link
Author

This PR fix the related update made by cesium-native side, however there are things to support versions never than cesium-native v0.33.0

There are breaking changes to be fixed, like newly introduced AppData parameter here:

https://github.com/CesiumGS/cesium-native/blame/c36ddc72d23588573470be6eddf232c80c18d0cd/CesiumIonClient/src/Connection.cpp#L250

The problem is known, #2558 by @jasonbeverage

@jasonbeverage
Copy link
Collaborator

I've updated osgEarth cesium to use the latest version of cesium-native, v0.37.0. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants