Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore neg_equiv_lemma #1004

Open
wants to merge 1 commit into
base: experiment-refined-ints
Choose a base branch
from
Open

Restore neg_equiv_lemma #1004

wants to merge 1 commit into from

Conversation

mamonet
Copy link
Collaborator

@mamonet mamonet commented Oct 16, 2024 •
edited
Loading

This PR restores neg_equiv_lemma which is needed for portable compress proofs in this PR cryspen/libcrux#631.

W95Psp
W95Psp requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't this lemma be two lemmas? 🤔
Also, can you add a definition in proof-libs/fstar/rust_primitives/Rust_primitives.Integers.fst? (a actual proof would be cool, but if that's taking too much time, put at least an let ... = admit ())

@mamonet
Copy link
Collaborator Author

mamonet commented Oct 16, 2024

Definition is already in proof-libs/fstar/rust_primitives/Rust_primitives.Integers.fst, some signatures were dropped while refactoring that module. I will check why it has no proof and see if it's easy to reason that lemma

@W95Psp
Copy link
Collaborator

W95Psp commented Oct 16, 2024

Ahh! Sorry I misunderstood! Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamonet @W95Psp