Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more features #1006

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Support more features #1006

merged 6 commits into from
Oct 16, 2024

Conversation

Nadrieril
Copy link
Collaborator

@Nadrieril Nadrieril commented Oct 16, 2024 •
edited
Loading

This PR is a series of small fixes to support more rust code.

@Nadrieril Nadrieril requested a review from W95Psp October 16, 2024 11:41
W95Psp
W95Psp approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great!
Just as a note: this adds the revealed type to Opaque types, but has nothing to do with trait resolution on opaque types (and thus doesn't impact #684)

.envrc Outdated Show resolved Hide resolved
@Nadrieril
Copy link
Collaborator Author

The corresponding charon fix is ready

@W95Psp W95Psp added this pull request to the merge queue Oct 16, 2024
Merged via the queue into hacspec:main with commit f48e911 Oct 16, 2024
22 of 26 checks passed
@Nadrieril Nadrieril deleted the tweaks branch October 16, 2024 13:54
@Nadrieril Nadrieril mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nadrieril @W95Psp