feat(cli): better version information #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions were broken: `cargo hax -V` was displaying the latest tag attached to the commit. So newer commits on main were tagged `v0.1.0-alpha`. Also, if hax is built without git, the version was empty. Now we use `CARGO_PKG_VERSION` as a fallback.
W95Psp
force-pushed
the
improve-hax-version
branch
from
e068f65
to
860c583
Compare
maximebuyse
approved these changes
Oct 16, 2024
W95Psp
force-pushed
the
improve-hax-version
branch
from
860c583
to
3a08c5a
Compare
This commit takes into account hax version for cargo cache. Also, if hax was built from a dirty git, the version is tainted with a hash of the driver itself.
W95Psp
force-pushed
the
improve-hax-version
branch
from
3a08c5a
to
f5c6f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cargo hax -Vandcargo hax --version:Versions were broken:
cargo hax -Vwas displaying the latest tag attached to the commit. So newer commits on main were taggedv0.1.0-alpha.Also, if hax is built without git, the version was empty. Now we use
CARGO_PKG_VERSIONas a fallback.cc @maximebuyse, you should get commit information from
cargo hax --version, notcargo hax -V.cargo hax ...is cached regardless ofhaxversion #801