Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic rec fstar #572

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Basic rec fstar #572

merged 1 commit into from
Mar 14, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Mar 13, 2024

This PR makes the F* backend output a let rec for simple recursive functions, not mutual ones.

Supporting mutual recursive functions is trickier because of namespaces, see #44.

@W95Psp W95Psp changed the base branch from main to enum-discr March 13, 2024 15:01
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Base automatically changed from enum-discr to main March 14, 2024 12:39
@W95Psp W95Psp enabled auto-merge March 14, 2024 12:41
@W95Psp W95Psp added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit e4f3580 Mar 14, 2024
11 checks passed
@W95Psp W95Psp deleted the basic-rec-fstar branch March 14, 2024 13:24
W95Psp added a commit that referenced this pull request Apr 9, 2024
PR #572 introduced basic support for non-mutual recursive definitions,
but that was working only in the implementation-only mode.

This PR fixes that: `rec` is now insterted in `fst` modules, no matter
whether we produce an interface or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants