Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename action for extracting ml-kem #704

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jun 6, 2024

This PR just renames the action that extracts ML-Kem from hax to extract-mlkem. Having this workflow named hax was very confusing (git blame blames myself sadly 😅).

Note: when merging this PR, we'll need to change the required jobs for merging in main

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 while you change required CI jobs you may also want to switch to the new rules as we need to do that at some point anyway.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Jun 10, 2024

What do you mean by new rules?

@franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer added the waiting-on-author Status: This is awaiting some action from the author. label Jun 21, 2024
This PR just renames the action that extracts ML-Kem from `hax` to
`extract-mlkem`. Having this workflow named `hax` was very confusing
(`git blame` blames myself sadly 😅).
@W95Psp W95Psp enabled auto-merge June 24, 2024 08:18
@W95Psp W95Psp added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 4552478 Jun 24, 2024
12 of 13 checks passed
@W95Psp W95Psp deleted the rename-mlkem-action branch June 24, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author Status: This is awaiting some action from the author.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants