-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine/f*): allow unsafe code #945
Conversation
This PR follows from #417 (comment), and from PR #867. It turns on the `unsafe` feature for the F* backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This crashes again on use.
Please update the Cargo.lock
and add a process that ensures that this doesn't happen.
Can you copy paste the error you get? This dependency things makes no sense to me, I don't get it. |
(things work fine on my laptop and on CI, so something is clearly wrong) I manually triggered https://github.com/hacspec/hax/actions/runs/11140855636 to se |
@franziskuskiefer can you try locally to run hax on |
Let's just update the lock file and get this in, and open an issue to investigate this. We shouldn't block this PR on that. |
Ok, but then I won't "add a process that ensures that this doesn't happen" in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but then I won't "add a process that ensures that this doesn't happen" in this PR.
yeah, that would be a little off-topic for this PR anyway.
This PR follows from
#417 (comment), and from PR #867.
It turns on the
unsafe
feature for the F* backend.