Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine/f*): allow unsafe code #945

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat(engine/f*): allow unsafe code #945

merged 2 commits into from
Oct 2, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Oct 2, 2024

This PR follows from
#417 (comment), and from PR #867.

It turns on the unsafe feature for the F* backend.

This PR follows from
#417 (comment), and
from PR #867.

It turns on the `unsafe` feature for the F* backend.
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crashes again on use.
Please update the Cargo.lock and add a process that ensures that this doesn't happen.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 2, 2024

Can you copy paste the error you get?
Can you also cargo clean in the tests folder and in the main folder before running the tests?

This dependency things makes no sense to me, I don't get it.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 2, 2024

(things work fine on my laptop and on CI, so something is clearly wrong)

I manually triggered https://github.com/hacspec/hax/actions/runs/11140855636 to se

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 2, 2024

@franziskuskiefer can you try locally to run hax on examples/chacha20? That's what the job above tests hax on

@franziskuskiefer
Copy link
Member

Let's just update the lock file and get this in, and open an issue to investigate this. We shouldn't block this PR on that.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 2, 2024

Ok, but then I won't "add a process that ensures that this doesn't happen" in this PR.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but then I won't "add a process that ensures that this doesn't happen" in this PR.

yeah, that would be a little off-topic for this PR anyway.

@W95Psp W95Psp added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit bfcd974 Oct 2, 2024
13 checks passed
@W95Psp W95Psp deleted the fstar-allow-unsafe branch October 2, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants