Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework trait resolution to support GATs #970

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

Nadrieril
Copy link
Collaborator

This reworks trait resolution as discussed offline: we only explore item bounds insofar as the Self type of the searched predicate is itself an associated type. This makes the search bounded, and makes it possible to support GATs in trait resolution.

Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks pretty nice to me.
I really like the redesign with PredicateSearcher, it's super clean and nice! 😃

Let's merge it!

@W95Psp W95Psp enabled auto-merge October 7, 2024 15:13
@Nadrieril
Copy link
Collaborator Author

Nadrieril commented Oct 7, 2024

🎉

(the charon breakage is expected and ok)

@W95Psp W95Psp added this pull request to the merge queue Oct 7, 2024
Merged via the queue into hacspec:main with commit 157eba3 Oct 7, 2024
12 of 13 checks passed
@Nadrieril Nadrieril deleted the gat branch October 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants