Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Normalize outside the binder" #976

Closed
wants to merge 1 commit into from
Closed

Revert "Normalize outside the binder" #976

wants to merge 1 commit into from

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Oct 8, 2024

This reverts commit f8035a7.

Fixes #974.

cc @Nadrieril

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 8, 2024 •
edited
Loading

btw, the change looks like identity to me, I don't get it, but I'm tired so that might be it 🤷‍♂️

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 8, 2024

@maximebuyse have you tried the PR on sandwich? This fixes my reproducer, not sure it fixes the original thing (I am not sure how to reproduce actually, in your issue there is no step for reproducing)

@maximebuyse
Copy link
Contributor

@maximebuyse have you tried the PR on sandwich? This fixes my reproducer, not sure it fixes the original thing (I am not sure how to reproduce actually, in your issue there is no step for reproducing)

@W95Psp Just tried and it fixes the original problem

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 8, 2024

Great, thanks! 😌

@maximebuyse maximebuyse added this pull request to the merge queue Oct 8, 2024
@Nadrieril
Copy link
Collaborator

Nadrieril commented Oct 8, 2024 •
edited
Loading

That commit was there to fix another problem however, as you can see from the charon failures. Please find a real fix.

EDIT: I made a real fix here: #977

@Nadrieril Nadrieril removed this pull request from the merge queue due to a manual request Oct 8, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 8, 2024

Sorry for that, was done in a hurry. Let's close in favor of your PR!

@W95Psp W95Psp closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximebuyse maximebuyse maximebuyse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in trait resolution
3 participants
@W95Psp @maximebuyse @Nadrieril