fix(engine): make consts fun. calls of arity 0 when there is an impl expr #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximebuyse
approved these changes
Oct 10, 2024
…expr The engine was dropping trait information when importing constants: now, if a constant `T::CONST` is an associated item of a non-inherent trait, we represent it `T::CONST` as a call to `CONST()` with the implementation expression for `T`. Note that, in the engine, constants are already represented as functions of arity zero. Rust functions of arity zero are represented as function that take exactly one `unit` input. Fixes #840.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine was dropping trait information when importing constants: now, if a constant
T::CONSTis an associated item of a non-inherent trait, we represent itT::CONSTas a call toCONST()with the implementation expression forT.Note that, in the engine, constants are already represented as functions of arity zero. Rust functions of arity zero are represented as functions that take exactly one
unitinput.Fixes #840.