extractPatchset: add git config core.abbrev=auto to format-patch call #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that the patch output is consistent, even if users use different values for that option. `haikuporter -e` is called by developers and its output ends up in the haikuports repository, so it should be as consistent as possible to avoid unnecessary noise. Other commands either don't produce any visible output or are run on the buildmaster systems where there is a defined environment, so it isn't necessary to define the git config explicitly. If there are other options which influence the output of `format-patch`, they should also be set explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the patch output is consistent, even if users use different values for that option.
haikuporter -eis called by developers and its output ends up in the haikuports repository, so it should be as consistent as possible to avoid unnecessary noise.Other commands either don't produce any visible output or are run on the buildmaster systems where there is a defined environment, so it isn't necessary to define the git config explicitly.
If there are other options which influence the output of
format-patch, they should also be set explicitly.