Add download file API #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Sep 11, 2024
fileserver/fileop.go
Outdated
| if len(parts) < 3 { | ||
| msg := "Invalid URL\n" | ||
| return &appError{nil, msg, http.StatusBadRequest} | ||
| } |
There was a problem hiding this comment.
这个检查应该是没有必要的吧，go router 里面已经匹配过了，不匹配的是不会进来的。
fileserver/fileop.go
Outdated
|
|
||
| decPath, err := url.PathUnescape(filePath) | ||
| if err != nil { | ||
| err := fmt.Errorf("failed to unescape file path %s: %v", filePath, err) |
| } | ||
|
|
||
| token := utils.GetAuthorizationToken(r.Header) | ||
| cookie := r.Header.Get("Cookie") |
fileserver/fileop.go
Outdated
| return "", &appError{err, "", http.StatusInternalServerError} | ||
| } | ||
| if status != http.StatusOK { | ||
| msg := "Access token not found" |
There was a problem hiding this comment.
这里应该返回 No permission to access file. C 的代码里面也改一下。
fileserver/fileop.go
Outdated
| User string `json:"user"` | ||
| } | ||
|
|
||
| func queryAccessToken(repoID, token, cookie, filePath, op string) (string, *appError) { |
There was a problem hiding this comment.
这里不要用 access token 这个概念，因为会和原来代码里面的 access token 概念混淆。应该叫 checkFileAccess。上面的数据结构就叫 UserInfo 就行了。C 代码也相应改一下概念。
server/http-tx-mgr.c
Outdated
|
|
||
| object = json_loadb (rsp_content, rsp_size, 0, &jerror); | ||
| if (!object) { | ||
| seaf_warning ("Parse response failed: %s.\n", jerror.text); |
There was a problem hiding this comment.
这里不应该叫 Parse response failed，应该用一个更明确的消息，比如 Failed to parse response when check file access in Seahub.
server/http-tx-mgr.c
Outdated
|
|
||
| user = json_object_get_string_member (object, "user"); | ||
| if (!user) { | ||
| seaf_warning ("Failed to find user in json.\n"); |
server/http-tx-mgr.c
Outdated
| g_free (cookie_header); | ||
| } | ||
| headers = curl_slist_append (headers, "Content-Type: application/json"); | ||
| curl_easy_setopt(curl, CURLOPT_HTTPHEADER, headers); |
There was a problem hiding this comment.
上面这些头部的设置应该都可以放在 http_post_common 里面的，http_get_common 也相应改一下。除了 Cookie 那个是特殊的。
server/http-tx-mgr.c
Outdated
| if (rsp_status != HTTP_OK) { | ||
| ret = -1; | ||
| seaf_warning ("Failed to get check access token %s from seahub %s: %d.\n", | ||
| token, rsp_content, rsp_status); |
| seaf_warning ("Failed to get check access token %s from seahub %s: %d.\n", | ||
| token, rsp_content, rsp_status); | ||
| goto out; | ||
| } |
There was a problem hiding this comment.
上面两个问题我看在获取 nickname 和获取链接信息的代码也有，都需要优化一下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.