Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for top-of-tree LLVM #8442

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Fix for top-of-tree LLVM #8442

merged 6 commits into from
Oct 19, 2024

Conversation

steven-johnson
Copy link
Contributor

No description provided.

@abadams
Copy link
Member

abadams commented Oct 18, 2024

Does this actually need to be conditional on llvm 20? I think getOrInsertDeclaration has existed for a long time.

@steven-johnson
Copy link
Contributor Author

steven-johnson commented Oct 18, 2024 •
edited
Loading

Does this actually need to be conditional on llvm 20? I think getOrInsertDeclaration has existed for a long time.

I didn't check.

EDIT: removing conditional.

EDIT 2: restored conditional; call didn't exist in LLVM17, which is what clang-tidy uses

@abadams abadams merged commit 87e7d4c into main Oct 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abadams abadams abadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steven-johnson @abadams