Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Updated with voxel observation mode. Added observation mode config supports #411

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

astonastonaston
Copy link
Contributor

  • Added the voxel observation mode allowing the convertion from RGBD sensor data to voxels.
  • Updated docs with some explanations, examples, and visualized images
  • Supported observation mode config so that observation hyper-parameters can be passed in during environment initializations

@StoneT2000 StoneT2000 self-requested a review July 10, 2024 20:48
Copy link
Member

@StoneT2000 StoneT2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far and looks very thorough. Just a few comments

mani_skill/utils/visualization/voxel_visualizer.py Outdated Show resolved Hide resolved
mani_skill/examples/demo_vis_voxel.py Outdated Show resolved Hide resolved
docs/source/user_guide/concepts/observation.md Outdated Show resolved Hide resolved
@astonastonaston
Copy link
Contributor Author

Now default voxelization configs are added. Voxelization can be done by just gym.make("PushCube-v1", obs_mode="voxel").

Copy link
Member

@StoneT2000 StoneT2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets limit the default voxel configs to just the tasks in the tabletop folder for now so remove the other defaults. We don't know what voxel settings are reasonable for the other tasks (and users won't use them probably). No default is better than possible errorneous default

mani_skill/envs/tasks/quadruped/quadruped_reach.py Outdated Show resolved Hide resolved
@astonastonaston
Copy link
Contributor Author

Now the voxel obs config for non-tabletop tasks are removed. The demos' segmentation supports are modified a bit for better visualizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants