Change the zero const to a signed integer in the de/player struct #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some replays, the value has been observed to be "-1" as opposed to "0"
|
Can we not assume it means "AI"? |
|
It is definitely related to AI players but I have replays with AI with this is still 0 so it's not simply whether it's an AI or not, we could name it something like "ai_unknown" for now. |
|
That works! |
|
Done. This now "fixes" #106 in the sense that it successfully parses although the meaning is still now known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some replays, the value has been observed to be "-1" as opposed to "0"
The meaning of the value is still not known. A reference replay can be found in #106