Remove copied proto src #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
nathanklick
reviewed
Nov 12, 2022
settings.gradle.kts
Outdated
Comment on lines
18
to
27
| gitRepositories { | ||
| include("hedera-protobufs") { | ||
| autoInclude.set(false) | ||
| uri.set("https://github.com/hashgraph/hedera-protobufs.git") | ||
| // optional, set what branch to use | ||
| // branch.set("main") | ||
| // you can also use a tag | ||
| tag.set("v0.31.0") | ||
| } | ||
| } |
There was a problem hiding this comment.
Need to actually use the hapiVersion property.
Suggested change
| gitRepositories { | |
| include("hedera-protobufs") { | |
| autoInclude.set(false) | |
| uri.set("https://github.com/hashgraph/hedera-protobufs.git") | |
| // optional, set what branch to use | |
| // branch.set("main") | |
| // you can also use a tag | |
| tag.set("v0.31.0") | |
| } | |
| } | |
| val hapiVersion by project | |
| gitRepositories { | |
| include("hedera-protobufs") { | |
| autoInclude.set(false) | |
| uri.set("https://github.com/hashgraph/hedera-protobufs.git") | |
| // optional, set what branch to use | |
| // branch.set("main") | |
| // you can also use a tag | |
| tag.set(hapiVersion) | |
| } | |
| } |
There was a problem hiding this comment.
I cleaned up those, I could not us hapiVersion as seems like settings happens before properties file is loaded. So I updated comments in code and updated README explaining
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
rbair23
approved these changes
Nov 14, 2022
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing copied protobuf sources, now clones hedera-protos repo during build. Depends on pull request #122