Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change to using solo-charts repo and solo-containers repo #648

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • Pointing to new chart repo
  • Rebrand any fst reference to solo

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…o-charts

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	README.md
#	docs/content/getting-started/deploy.md
#	src/commands/network.mjs
#	src/commands/node.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners October 4, 2024 18:10
@JeffreyDallas JeffreyDallas self-assigned this Oct 4, 2024
@JeffreyDallas JeffreyDallas added the Improvement Code changes driven by non business requirements label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   29s ⏱️ +2s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a35f342. ± Comparison against base commit be3fb6b.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
ProfileManager determine chart values for a profile should determine FST chart values [profile = test] ‑ ProfileManager determine chart values for a profile should determine FST chart values [profile = test]
ProfileManager prepareValuesForFstChart should set the value of a key to the contents of a file ‑ ProfileManager prepareValuesForFstChart should set the value of a key to the contents of a file
ProfileManager determine chart values for a profile should determine Solo chart values [profile = test] ‑ ProfileManager determine chart values for a profile should determine Solo chart values [profile = test]
ProfileManager prepareValuesForSoloChart should set the value of a key to the contents of a file ‑ ProfileManager prepareValuesForSoloChart should set the value of a key to the contents of a file

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   59s ⏱️ +3s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a35f342. ± Comparison against base commit be3fb6b.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
ProfileManager determine chart values for a profile should determine FST chart values [profile = test] ‑ ProfileManager determine chart values for a profile should determine FST chart values [profile = test]
ProfileManager prepareValuesForFstChart should set the value of a key to the contents of a file ‑ ProfileManager prepareValuesForFstChart should set the value of a key to the contents of a file
ProfileManager determine chart values for a profile should determine Solo chart values [profile = test] ‑ ProfileManager determine chart values for a profile should determine Solo chart values [profile = test]
ProfileManager prepareValuesForSoloChart should set the value of a key to the contents of a file ‑ ProfileManager prepareValuesForSoloChart should set the value of a key to the contents of a file

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

E2E Test Report

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0dbc8bb.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

E2E Test Report

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit a35f342.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Oct 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for be3fb6b1 86.54%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (be3fb6b) Report Missing Report Missing Report Missing
Head commit (a35f342) 4237 3379 79.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#648) 52 45 86.54%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (1761455) to head (a35f342).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/network.mjs 75.00% 4 Missing ⚠️
src/commands/cluster.mjs 80.00% 2 Missing ⚠️
test/e2e/e2e_node_util.js 50.00% 1 Missing ⚠️
test/test_util.js 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   79.52%   79.54%   +0.01%     
==========================================
  Files          42       42              
  Lines        5069     5069              
  Branches      705      705              
==========================================
+ Hits         4031     4032       +1     
+ Misses       1037     1036       -1     
  Partials        1        1              
Files with missing lines Coverage Δ
src/commands/account.mjs 68.62% <100.00%> (ø)
src/commands/flags.mjs 96.10% <100.00%> (ø)
src/commands/init.mjs 80.35% <ø> (ø)
src/commands/mirror_node.mjs 66.66% <ø> (ø)
src/commands/node.mjs 74.57% <ø> (ø)
src/commands/node/tasks.mjs 91.33% <ø> (ø)
src/commands/prompts.mjs 63.01% <100.00%> (ø)
src/commands/relay.mjs 73.68% <100.00%> (ø)
src/core/account_manager.mjs 80.73% <100.00%> (ø)
src/core/constants.mjs 94.38% <100.00%> (ø)
... and 9 more

Impacted file tree graph

JeffreyDallas and others added 2 commits October 7, 2024 09:06
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
@jeromy-cannon jeromy-cannon merged commit a81d883 into main Oct 9, 2024
38 of 39 checks passed
@jeromy-cannon jeromy-cannon deleted the 00647-D-switch-chart-repo branch October 9, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to solo-charts and solo-containers
2 participants