Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix failing test case and correct package.json test runs #672

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • fix failing test case
  • correct package.json test runs

Related Issues

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…icate run of integration folder

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon self-assigned this Oct 11, 2024
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   40 suites  ±0   6s ⏱️ -1s
112 tests ±0  112 ✅ ±0  0 💤 ±0  0 ❌ ±0 
124 runs  ±0  124 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c4fd4de. ± Comparison against base commit c81b3b4.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   40 suites  ±0   21s ⏱️ ±0s
112 tests ±0  112 ✅ ±0  0 💤 ±0  0 ❌ ±0 
124 runs  ±0  124 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c4fd4de. ± Comparison against base commit c81b3b4.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

E2E Test Report

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c4fd4de.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c81b3b41
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c81b3b4) Report Missing Report Missing Report Missing
Head commit (c4fd4de) 14237 9575 67.25%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#672) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (65a1b53) to head (c4fd4de).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   69.15%   66.14%   -3.02%     
==========================================
  Files          40       38       -2     
  Lines       14560    14237     -323     
  Branches      779      734      -45     
==========================================
- Hits        10069     9417     -652     
- Misses       4444     4778     +334     
+ Partials       47       42       -5     

see 20 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review October 11, 2024 10:46
@jeromy-cannon jeromy-cannon merged commit 2c39105 into main Oct 11, 2024
37 of 38 checks passed
@jeromy-cannon jeromy-cannon deleted the 00671-fix-test-case-failure branch October 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test case failure that got merged to main 20241010
2 participants