Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): change to synth from synthScope for #2755 #2756

Merged
merged 2 commits into from
Apr 18, 2023
Merged

chore(docs): change to synth from synthScope for #2755 #2756

merged 2 commits into from
Apr 18, 2023

Conversation

tolluset
Copy link
Contributor

@tolluset tolluset commented Apr 2, 2023 •
edited
Loading

Related issue

Fixes #2755

Description

The document shows an example using synthScope that can test the Construct type. But this document is for most beginners, so we want to test the Stack, because followed docs were showing examples of Stack.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tolluset tolluset mentioned this pull request Apr 2, 2023
Closed
1 task
@tolluset tolluset marked this pull request as ready for review April 2, 2023 15:34
@tolluset tolluset requested review from a team and robin-norwood as code owners April 2, 2023 15:34
@tolluset tolluset requested review from ansgarm and DanielMSchmidt and removed request for a team April 2, 2023 15:34
@tolluset
Copy link
Contributor Author

@DanielMSchmidt
Thank you for review! Is there something to require for merge this PR?

@ansgarm ansgarm merged commit 1811830 into hashicorp:main Apr 18, 2023
@mutahhir mutahhir mentioned this pull request Apr 18, 2023
Merged
@tolluset tolluset deleted the docs/unit-test-synth branch April 18, 2023 14:12
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@robin-norwood robin-norwood Awaiting requested review from robin-norwood

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit Tests: Use Synth than SynthScope in typescript test
5 participants
@tolluset @hashicorp-cla @DanielMSchmidt @ansgarm @team-tf-cdk