Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Support Kotlin Build Scripts in Gradle Project and Cdktf Version Detection #3760

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(cli): Support Kotlin Build Scripts in Gradle Project and Cdktf Version Detection #3760

wants to merge 3 commits into from
+8 −2

Conversation

nelsonleblanc-rl
Copy link

@nelsonleblanc-rl nelsonleblanc-rl commented Nov 2, 2024 •
edited
Loading

Related issue

Fixes # 3759

Description

Support Kotlin build scripts for Gradle by enumerating build.gradle.kts in isGradleProject and getGradlePackageVersionFromBuild functions.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@nelsonleblanc-rl nelsonleblanc-rl requested a review from a team as a code owner November 2, 2024 05:53
@nelsonleblanc-rl nelsonleblanc-rl requested review from mutahhir and DanielMSchmidt and removed request for a team November 2, 2024 05:53
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Nov 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nelsonleblanc-rl nelsonleblanc-rl marked this pull request as draft November 2, 2024 05:53
@nelsonleblanc-rl nelsonleblanc-rl marked this pull request as ready for review November 2, 2024 20:06
@nelsonleblanc-rl nelsonleblanc-rl mentioned this pull request Nov 4, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@DanielMSchmidt DanielMSchmidt Awaiting requested review from DanielMSchmidt DanielMSchmidt is a code owner automatically assigned from hashicorp/cdktf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nelsonleblanc-rl