Add support for ecdsa ssh keys #13327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ECDSA key types (256, 384, and 521) to supported types that can be generated for key replacement on guest.
Adds a new `key_type` option to the Vagrantfile ssh configuration. It defaults to :auto which allows auto detection of key type to use. Otherwise it can be set to an explicit type supported by Vagrant.
If key type is defined as :auto, detect best key type to use. If no acceptable key type is detected as supported by the server, raise an error. If unable to determine supported key types from the server, fallback to original behavior of rsa type key. If key type is defined as custom value, use that type if the server supports it, or if the supported types cannot be read. Otherwise, raise an error informing the user that the key type is not supported.
This patches net-ssh so it will properly handle loading and using ecdsa private keys. Patching is restricted to tested versions.
allisonlarson
approved these changes
Jan 10, 2024
|
Thanks @chrisroberts. Greatly appreciate it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for generating ecdsa ssh key pairs. This was prompted
by #13323 which raised the issue of ed25519 keys not being FIPS
compliant and causing connection issues. This PR adds a new option
to the ssh configuration providing the ability to specify a desired
key type:
Some monkey patching to the net-ssh library is included with this
PR that will be removed once the modifications can be added upstream.
Fixes #13323