[WIP] Support for standard JSON post request #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fully and automatically support the parsing and validation of a json object of variable values referenced by their names into a
VariableValuesobject.This project is using Aeson already so the interface will use the aeson AST for JSON.
The goal is to address #145, #132, and to replace #128
Schematically, the idea is to follow the generation of the schema by a double tree descending job where we compare the GraphQL's expected type and the JSON's observed value to either return an error or return the expected Haskell/GraphQL value.
For now, the code will reuse the Validation module and the execution module. The actual variables parsing will be done in the Validation module.
I'm open to any suggestion or help.