Implements split and merge commands. #21
Conversation
test/Test/IO/Regiment/IO.hs
Outdated
| gamble (chooseInt (1,5)) $ \numInputs -> | ||
| gamble (vectorOf numInputs $ vectorOf n $ (mkJack_ $ genRow fmt) `suchThat` (not . BS.null)) $ \vrs -> testIO $ do | ||
| let sc = SortColumn <$> [0 .. ((formatColumnCount fmt) - 1)] |
There was a problem hiding this comment.
Deciding to sort on all the columns so as to remove ambiguity
There was a problem hiding this comment.
Build failed on a very high number of columns (~ 100). Have yet to investigate but the details in http://boris.ambiata.com/build/213251 are going to be quite difficult to disentangle.
test/Test/IO/Regiment/IO.hs
Outdated
| @@ -151,7 +151,8 @@ prop_regiment = | |||
| ExitFailure _ -> return $ counterexample ("diff failed: " <> so') False | |||
|
|
|||
| prop_regiment_split_merge = | |||
| gamble (arbitrary `suchThat` (> 0)) $ \n -> | |||
| -- gamble (arbitrary `suchThat` (> 0)) $ \n -> | |||
| gamble (chooseInt (1, 50)) $ \n -> | |||
There was a problem hiding this comment.
Setting number of columns to be between 1 and 50. This finally results in tests passing but this is unsatisfactory.
test/Test/IO/Regiment/IO.hs
Outdated
| gamble genNonNullSeparator $ \sep -> | ||
| gamble (genRestrictedFormat sep) $ \fmt -> | ||
| gamble (chooseInt (1,5)) $ \numInputs -> | ||
| gamble (vectorOf numInputs $ vectorOf n $ (mkJack_ $ genRow fmt) `suchThat` (not . BS.null)) $ \vrs -> testIO $ do |
There was a problem hiding this comment.
Generating a number first and then passing it to vectorOf instead of using the list combinators is ruining your shrinking. If you get rid of n and numInputs and change this last line to:
gamble (listOfN 1 5 $ listOfN 1 100 $ (mkJack_ $ genRow fmt) `suchThat` (not . BS.null)) $ \vrs -> testIO $ doyou might get a better counterexample because it will be able to shrink to subsets of the list which is failing.
novemberkilo
force-pushed
the
topic/splits
branch
from
3684ce2
to
f71c334
Compare
| # merge-tmps | ||
|
|
||
| # write to stdout | ||
| $REGIMENT merge-tmps "/path/to/dir1" "/path/to/dir2" |
There was a problem hiding this comment.
doesn't this fail because there's no data in /path/to/dir1 ?
There was a problem hiding this comment.
oh, you're just doing dry run, nvm
src/Regiment/IO.hs
Outdated
| exists <- liftIO $ SD.doesDirectoryExist tmp | ||
| if exists | ||
| then | ||
| left . RegimentIOCreateDirectoryError $ "Target directory " <> T.pack tmp <> " should not exist, it will be created an filled." |
There was a problem hiding this comment.
This seems kind of savage, you should really put the directory name in the data type and do the rendering elsewhere
src/Regiment/IO.hs
Outdated
| tryEitherT handler . liftIO $ SD.createDirectoryIfMissing True tmp | ||
| where | ||
| handler :: SomeException -> RegimentIOError | ||
| handler e = RegimentIOCreateDirectoryError $ T.pack tmp <> " Error: " <> T.pack (show e) |
|
👍 |
novemberkilo
force-pushed
the
topic/splits
branch
from
cc677da
to
329ddd7
Compare
! @jystic @markhibberd
Tagging the related issue #15
/jury approved @jystic