Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “Significant change” guideline #10521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Nov 4, 2024

Add some heuristic to decide which changes are “significant” and a checkbox to remind PR authors to add the tag if appropriate.

We talked about this in the “release post-mortem” meeting. Rewrites and comments welcome.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Add some heuristic to decide which changes are “significant”
and a checkbox to remind PR authors to add the tag if appropriate.
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks!

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Nov 4, 2024

@Kleidukos I am pinging you since he chaired the meeting and you might have something to say.

Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the spirit!

@ffaf1 ffaf1 added the merge me Tell Mergify Bot to merge label Nov 5, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants