Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

harrisonritz
Copy link

update installation instructions with what works on Brown's OSCAR

update installation instructions with what works on Brown's OSCAR
Copy link
Contributor

@AlexanderFengler AlexanderFengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for contributing. left a comment.
when that is fixed we can merge.

README.rst Outdated
@@ -181,26 +181,23 @@ If you do not have **hdf5** or **netcdf4** installed, you can use conda to insta

::

conda install -c conda-forge hdf5
conda install -c conda-forge netcdf4
conda install hdf5 netcdf4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of deleted the original instructions, could you just add a section that is specific to oscar?

make new section
Copy link
Author

@harrisonritz harrisonritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderFengler ok, this commit reinstates the old instructions and adds a new section.
(are you 100% sure that they work?)


To make use of the LAN fuctionalities, you need to install `pytorch`_.

::

pip install torch==1.13.1 torchvision==0.14.1 torchaudio==0.13.1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderFengler I reinstated the repeat of the torch install instruction on line 198/204. you should probably remove one of these (I think torch==1.13.1 is outdated relative to your docker file ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants