-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.rst #113
base: master
Are you sure you want to change the base?
Update README.rst #113
Conversation
update installation instructions with what works on Brown's OSCAR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank for contributing. left a comment.
when that is fixed we can merge.
README.rst
Outdated
@@ -181,26 +181,23 @@ If you do not have **hdf5** or **netcdf4** installed, you can use conda to insta | |||
|
|||
:: | |||
|
|||
conda install -c conda-forge hdf5 | |||
conda install -c conda-forge netcdf4 | |||
conda install hdf5 netcdf4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of deleted the original instructions, could you just add a section that is specific to oscar?
make new section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderFengler ok, this commit reinstates the old instructions and adds a new section.
(are you 100% sure that they work?)
|
||
To make use of the LAN fuctionalities, you need to install `pytorch`_. | ||
|
||
:: | ||
|
||
pip install torch==1.13.1 torchvision==0.14.1 torchaudio==0.13.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderFengler I reinstated the repeat of the torch install instruction on line 198/204. you should probably remove one of these (I think torch==1.13.1 is outdated relative to your docker file ).
update installation instructions with what works on Brown's OSCAR