Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdk: open_road_configuration: Get KLayout technology file and metal fill configuration from internal PDK setup #173

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

lpawelcz
Copy link
Collaborator

This PR modifies open_road_configuration so that it is now possible for a PDK dependency to define additional two fields:

  • metal (density) fill configuration JSON file,
  • KLayout technology LYT file.

The last one is required for GDS configuration so this field was marked as mandatory. The files are used by rules: place_and_route and gds_write. Default values specified for each PDK can be overwritten by attributes density_config and klayout_lyt of those rules.

It is reasonable to move handling of those files to the PDK dependencies setup because these are PDK-specific and can be reused for multiple designs.

CC @proppy

Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@@ -59,6 +59,7 @@ open_road_pdk_configuration(
"M7": "0.5",
},
global_routing_signal_layers = "M2-M7",
klayout_tech_file = "@rules_hdl//dependency_support/org_theopenroadproject_asap7:asap7.lyt",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: no fill config by default in ASAP7?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the flow examples in OpenROAD-flow-scripts - no, there is no density_fill stage in the flow targeting ASAP7 so there is no need for specifying the config file

Copy link
Collaborator

@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpawelcz
Copy link
Collaborator Author

Hi @QuantamHD, please take a look at this PR. Merging this would unblock our work in google/xls#1031

@QuantamHD QuantamHD merged commit 5e2ec27 into hdl:main Jul 27, 2023
4 checks passed
@lpawelcz
Copy link
Collaborator Author

Thanks a lot!

@lpawelcz lpawelcz deleted the improve-pdk-support branch July 28, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants