New input format #5
Conversation
There was a problem hiding this comment.
See inline comment. I also assigned @johnbradley, as he'd understand the code and its history much better.
|
@thibaulttabarin please do not simply "resolve" comments (what GitHub calls conversations) without an explanation or corresponding code change. Otherwise, you're essentially signaling that you're dismissing those comments, and without explanation, which was presumably not your intent. |
typo fix Co-authored-by: John Bradley <johnbradley2008@gmail.com>
Co-authored-by: John Bradley <johnbradley2008@gmail.com>
Co-authored-by: John Bradley <johnbradley2008@gmail.com>
Change the increase value to 10% in the example shown in the documentation
- The code int(abs()) force the bbox to be a list of positive integer is unnessacery in this case - Some package framework using crop function require a list of integer but not crop from PIL - The code int(abs()) was reminescence from habit to transfer the code to the right format - Since this code added some confusion and it is currently unnessecary it can be remove
…o new-input-format
Replace the absolute link with relative link for better portability between branches
There was a problem hiding this comment.
See inline suggestions and comments. I think there's one remaining issue, namely Metadata json file generated by [Drexel_metadata_rformatter] (https://github.com/hdr-bgnn/drexel_metadata_formatter) (BTW notice typo and extraneous space between ] and (). I think this needs to refer to the drexel_metadata repo as the one that's generating the metadata including the bounding box, followed perhaps by saying that this code needs the metadata to be reformatted as done by the drexel_metadata_reformatter code. Isn't that right?
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
Modifiy the Crop_imae_main.py
README.md