Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rotp β†’ 6.3.0 (unknown) #118

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 31, 2023


Welcome to Depfu πŸ‘‹

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!


Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rotp (~> 6.2.0 β†’ ~> 6.3.0) Β· Repo Β· Changelog

Release Notes

6.3.0

6.3.0 (2023-08-30)

Features

  • Allow for non-standard provisioning URI params, eg. image/icon (#91) (45d8aac)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 31, 2023
@Skulli
Copy link

Skulli commented Mar 18, 2024

GHSA-x2h8-qmj4-g62f

@chrisdebruin
Copy link

Can this be merged? There is a CVE-2024-28862 in rotp 6.2 dependency. Thanks

@neongrau
Copy link

pretty please someone do a
@​depfu merge

@arinchoi03
Copy link

arinchoi03 commented Mar 22, 2024

please merge this soon, thank you! maybe @robertomiranda @pedrofurtado ?

@ash-rc
Copy link

ash-rc commented Mar 26, 2024

Adding to this, this needs to be updated ASAP @robertomiranda @guilleiguaran @bithavoc

@guilleiguaran guilleiguaran merged commit 3a4db76 into main Mar 26, 2024
21 checks passed
@depfu depfu bot deleted the depfu/update/rotp-6.3.0 branch March 26, 2024 18:52
@chrisdebruin
Copy link

Thanks a lot @guilleiguaran

@jeffbax
Copy link

jeffbax commented Mar 27, 2024

Is there going to be a new release of active_model_otp itself with the dependency change?

@chriskoelle
Copy link

@guilleiguaran any timeline on a release for this?

@bithavoc
Copy link
Member

bithavoc commented Apr 9, 2024

@guilleiguaran rubygems

@nathansamson
Copy link

Why not make the dependency less strict '~> 6.3' probably works as well (assuming rotp follows semver correctly) and gives users of this gem easier upgrade paths

@chriskoelle
Copy link

@guilleiguaran @robertomiranda @bithavoc sorry to be a bother but could somebody please push a rubygems release for this? πŸ™ CVE-2024-28862 was published a month ago.

@robertomiranda
Copy link
Member

released https://rubygems.org/gems/active_model_otp/versions/2.3.4

@arinchoi03
Copy link

yay thank you so much!

@jeffbax
Copy link

jeffbax commented Apr 18, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.