Array API #1022
Open
Array API #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where negative numbers could be represented by uint8.
In cases involving large numbers where the `dtype` parameter was unchanged, precision loss occurred due to intermediate casting to float32 (in `__local_op`) before casting back to the original `dtype`. Fixed by not doing the intermediate casting.
Fixed bug in `ht.any` where `keepdim` argument was not working when `axis=None` (same fix as 136e1b7)
f0a169b introduced a change in ht.abs where the dtype is not promoted to float by default. This caused the tests to fail.
|
Thank you for the PR! |
|
All Linalg tests are skipped for now. |
mtar
reviewed
Jul 16, 2024
heat/array_api/test/skips.txt
Outdated
There was a problem hiding this comment.
This file contains all function tests that sometimes fail and sometimes not. It skips them. Might be easier to fix later.
mtar
reviewed
Jul 16, 2024
heat/array_api/test/xfails.txt
Outdated
There was a problem hiding this comment.
This file contains function tests that failed every single time. These are expected to fail again. Mostly not implemented or not compliant functions.
ClaudiaComito
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Let's add @neosunhan 's name to the list of contributors . Otherwise this can be merged, great job @mtar and @neosunhan !
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement array API according to the Python array API standard (version 2021.12)
See #774 for more information.
Changes proposed:
EDIT (Claudia): This PR also introduces a workflow to test compliance whenever a PR is reviewed.
EDIT2: workflow triggered manually, API version 2023.12
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no
skip ci