Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/1563 Add Dynamic Mode Decomposition (DMD) #1639

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Sep 3, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #1563

Type of change

New feature (non-breaking change which adds functionality)

Does this change modify the behaviour of other functions? If so, which?

no

@mrfh92 mrfh92 added ESAPCA relevant for the ESA-funded project "ESAPCA" high-level functions High-level machine-learning algorithms labels Sep 3, 2024
@mrfh92 mrfh92 marked this pull request as ready for review September 3, 2024 11:41
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Thank you for the PR!

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 85.26316% with 28 lines in your changes missing coverage. Please review.

Project coverage is 92.02%. Comparing base (3e9ab1c) to head (8b85afe).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
heat/decomposition/dmd.py 79.25% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
- Coverage   92.13%   92.02%   -0.11%     
==========================================
  Files          83       84       +1     
  Lines       12165    12333     +168     
==========================================
+ Hits        11208    11350     +142     
- Misses        957      983      +26     
Flag Coverage Δ
unit 92.02% <85.26%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Sep 6, 2024

todo: think about what .predict should do

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thank you for the PR!

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESAPCA relevant for the ESA-funded project "ESAPCA" high-level functions High-level machine-learning algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DMD
1 participant