Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data.load_balancer_type(s) data sources #991

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jooola
Copy link
Member

@jooola jooola commented Sep 6, 2024

Closes #945

@jooola jooola changed the title feat: add load_balancer_type(s) data sources feat: add data.load_balancer_type(s) data sources Sep 6, 2024
@jooola jooola force-pushed the plugin-framework-load-balancer-type branch from 84ad077 to 351df2b Compare September 10, 2024 12:18
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 81.69014% with 26 lines in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (ac90449) to head (77912bd).

Files with missing lines Patch % Lines
internal/loadbalancertype/data_source.go 81.42% 17 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   69.67%   69.88%   +0.20%     
==========================================
  Files          64       65       +1     
  Lines        8010     8152     +142     
==========================================
+ Hits         5581     5697     +116     
- Misses       1727     1744      +17     
- Partials      702      711       +9     
Flag Coverage Δ
e2e 69.88% <81.69%> (+0.20%) ⬆️
unit 34.21% <38.02%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola marked this pull request as ready for review September 12, 2024 13:41
@jooola jooola requested a review from a team as a code owner September 12, 2024 13:41
@jooola jooola force-pushed the plugin-framework-load-balancer-type branch from 351df2b to aefc8a7 Compare September 12, 2024 14:13
@jooola
Copy link
Member Author

jooola commented Sep 12, 2024

This data source is almost finished, it is missing the following:

  • the hcloud-go library does not provide the deprecated string field for the load balancer type https://docs.hetzner.cloud/#load-balancer-types-get-a-load-balancer-type, and I am not sure if we want to wait for the backend to implement the new deprecation object before we at it here.
  • the documentation is written, but I am not sure if I missed anything.
  • I am not sure what the -x suffix is used for in the docs sidebar sidebar_current template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add data source load_balancer_types
1 participant