feat(cli): send the frame-cache health counters to render_complete - #3388
Open
vanceingalls wants to merge 1 commit into
Open
feat(cli): send the frame-cache health counters to render_complete#3388vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
`ExtractionPhaseBreakdown` has collected `cachePublishFailures`, `cacheGcEvictions`, `cacheGcBytesFreed` and `cacheAgedPartialsCleared` for a while, and `extractPayload` dropped all four on the floor — they reached the perf summary and stopped there. `cachePublishFailures` is the one worth a dashboard: the render still succeeds from the partial dir, so nothing surfaces to the user, but every later render re-extracts. Its own docstring calls it "the first signal that warm renders are silently going cold", and until now that signal had no consumer. The GC counters give it a denominator — evicted on purpose, or failed to publish. Both writers (`render.ts` for the CLI, `studioRenderTelemetry.ts` for studio renders) map them, and the mapping test asserts all four with distinct non-zero values so a crossed pair cannot pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up flagged in the #1915 review:
ExtractionPhaseBreakdowncollects four frame-cache counters thatextractPayloadnever forwarded, so they reachedRenderPerfSummaryand stopped there.extract_cache_publish_failures— the one to alert on. A failed atomic publish still lets the render succeed from the partial dir, so nothing surfaces, but every later render re-extracts. Its docstring calls it "the first signal that warm renders are silently going cold"; until now that signal had no consumer.extract_cache_gc_evictions,extract_cache_gc_bytes_freed,extract_cache_aged_partials_cleared— the denominator: evicted on purpose, or failed to publish.Both writers map them (
render.tsfor CLI renders,studioRenderTelemetry.tsfor studio ones). The mapping test asserts all four with distinct non-zero values, so a crossed pair cannot pass — the fixture previously had them all at 0.🤖 Generated with Claude Code