Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null check for public key parameter. #944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix null check for public key parameter. #944

wants to merge 1 commit into from

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented May 14, 2024 •
edited
Loading

Addendum for #908 as discussed in 1. Resolves #907.

Footnotes

  1. https://github.com/hierynomus/sshj/pull/908/files#r1600044608 ↩

@dkocher dkocher requested a review from hierynomus as a code owner May 14, 2024 17:07
@hierynomus
Copy link
Owner

Actually the null check is not for the parameter, but was once meant to only ensure that a subsequent call to init would not re-initialize. Need to check what the potential problem is.

@dkocher dkocher mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hierynomus hierynomus Awaiting requested review from hierynomus hierynomus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No initialization of public key depending on constructor usage of file key provider
2 participants
@dkocher @hierynomus